Skip to content

Fix out-of-range recursion in interpolation_search_by_recursion #15333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RizgarOzan wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

Fix out-of-range recursion in interpolation_search_by_recursion #15333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions searches/interpolation_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,24 @@ def interpolation_search_by_recursion(
1
>>> interpolation_search_by_recursion([0, 5, 7, 10, 15], 100) is None
True
>>> interpolation_search_by_recursion([0, 5, 7, 10, 15], 16) is None
True
>>> interpolation_search_by_recursion([0, 5, 7, 10, 15], -1) is None
True
>>> interpolation_search_by_recursion([0, 3, 6, 12, 14, 15, 20], 10) is None
True
>>> interpolation_search_by_recursion([], 1) is None
True
>>> interpolation_search_by_recursion([5, 5, 5, 5, 5], 3) is None
True
"""
if right is None:
right = len(sorted_collection) - 1
if left > right:
return None
# avoid divided by 0 during interpolation
if sorted_collection[left] == sorted_collection[right]:
if sorted_collection[left] == item:
return left
return None
return left if sorted_collection[left] == item else None

point = left + ((item - sorted_collection[left]) * (right - left)) // (
sorted_collection[right] - sorted_collection[left]
Expand Down
Loading