Repository navigation
The chrome ground drifts visibly whenever the window is on screen - #905
Merged
Merged
Conversation
Owner, 2026-10-28: "I don't see it moving". Two causes in #900. The drift ran only in the focused window, so it froze whenever another app had focus. And 10 px over a minute changed the coated pixels by 1 to 3 grey levels, which nobody can see. - The owner tuned it live, watching the dev app: it now sways up to 120 px across and 84 px down along two sines (25 s and 33 s), on a 50 ms timer (under 2 px a step). The stills overhang the window by 128 px. Over 3 s, 90% of pixels now change by up to 11 grey levels, against 3 before. - It moves whenever the window is on screen, even beside a focused app. It pauses where it is while the window is minimised or hidden (main's window:visible), while a recording or livestream runs, and under Reduce Motion. - The new session:take-running event comes from main's capture state (takeRunning in capture-state.ts). Every window gets it, and a window that loads during a take is told on load. A Clips-only ring is no take, and neither is a lost socket. The aux windows' preload allowlists gain onTakeRunning. - Design skill, glossary and docs/live-backgrounds.md updated.
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 29, 2026
TheOrcDev
added a commit
that referenced
this pull request
Oct 29, 2026
) Owner, 2026-10-29: "remove that animation on the background of the app, I don't like it". Reverts both drift PRs, so plan 208 D5 holds again: nothing moves outside the Welcome screen. - ChromeGround is back to the display-sized still with no drift layer, timer or overhang. - Main no longer publishes session:take-running; the IPC contract, preload API, allowlists and takeRunning() helper go with it (the drift was their only user). - probe:ui-glass no longer holds Reduce Motion for the drift. - Design skill, glossary and docs/live-backgrounds.md say the ground is a still. The Welcome screen's live backdrop is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner, 2026-10-28: "I don't see it moving." That was true of #900, for two reasons:
Change
window:visible);session:take-runningis a new main-to-renderer event.takeRunning()from its own capture state. A Clips-only ring is not a take, and neither is a lost socket.onTakeRunning.docs/live-backgrounds.mdare updated.Gates
check:text-files;takeRunningtests: takes, the Clips ring, a lost socket;probe:ui-glass. The owner asked to merge.Known issue, follow-up owed