Allow clippy::double_must_use on the async_trait BlobStore - #73
Merged
Merged
Conversation
Clippy 1.99 added double_must_use, and it fires on the methods async_trait generates for BlobStore: each is marked #[must_use] and returns a boxed future that is must-use already. CI has failed on it since 2026-10-02. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fylorn
added a commit
that referenced
this pull request
Oct 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy 1.99 added
double_must_use, which fires on the methodsasync_traitgenerates forBlobStore(crates/common/src/blob_store.rs): each is marked#[must_use]and returns a boxed future that is must-use already. The code is macro-generated, so the lint is allowed on the trait.Rust Check & Testhas failed on dev since 2026-10-02 because of it; this is the only#[async_trait]trait definition in the workspace.Clippy used to stop at
common, so this run is also the first time 1.99 checks the remaining crates.🤖 Generated with Claude Code