Skip to content

Allow clippy::double_must_use on the async_trait BlobStore #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fylorn merged 1 commit into from
Oct 2, 2026
Merged

Allow clippy::double_must_use on the async_trait BlobStore #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/common/src/blob_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ pub struct BlobKeyHint<'a> {
pub field: &'a str,
}

// `async_trait` marks every generated method `#[must_use]`, and the boxed
// future it returns is already must-use; clippy 1.99's `double_must_use`
// flags that generated code, which there is no way to change from here.
#[allow(clippy::double_must_use)]
#[async_trait]
pub trait BlobStore: Send + Sync + std::fmt::Debug {
/// Whether this store can actually offload. `InlineStore` returns
Expand Down
Loading