Skip to content

fix(tests): reduce async timing flakes#239

Merged
yordis merged 1 commit intomasterfrom
yordis/fix-test-timing-headroom
May 9, 2026
Merged

fix(tests): reduce async timing flakes#239
yordis merged 1 commit intomasterfrom
yordis/fix-test-timing-headroom

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 8, 2026

  • Give asynchronous subscription and authorization propagation room to settle under slower CI load.
  • Reduce false negatives from timing-sensitive tests without changing production behavior.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 8, 2026

PR Summary

Low Risk
Low risk: changes are limited to test retry/timeout tuning and an import ordering tweak, with no production code impact.

Overview
Improves test stability under slower CI by increasing wait budgets for async propagation.

In GetInfoTests, the helper that waits for persistent subscriptions to become Live now retries longer (20 iterations) with a longer delay between polls (1s). In StreamBasedAuthPolicyRegistryTests, the shared async Timeout is doubled to 10 seconds (plus a minor using reorder).

Reviewed by Cursor Bugbot for commit 1cbf3ad. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 2 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22b9dcd5-ef8c-4781-9ac9-144ea3adf62e

📥 Commits

Reviewing files that changed from the base of the PR and between 6f1e444 and 1cbf3ad.

📒 Files selected for processing (2)
  • src/EventStore.Core.Tests/Services/Transport/Grpc/PersistentSubscriptionTests/GetInfoTests.cs
  • src/EventStore.Core.XUnit.Tests/Authorization/StreamBasedAuthPolicyRegistryTests.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/fix-test-timing-headroom

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis yordis merged commit b093a01 into master May 9, 2026
22 checks passed
@yordis yordis deleted the yordis/fix-test-timing-headroom branch May 9, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant