Skip to content

fix(tests): reduce async timing flakes #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 1 commit into from
May 9, 2026
+4 −4
Merged

fix(tests): reduce async timing flakes #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...EventStore.Core.Tests/Services/Transport/Grpc/PersistentSubscriptionTests/GetInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,9 +781,9 @@ private static async Task WaitForSubscriptionsToBeLive(PersistentSubscriptions.P

for (int i = 0; resp.Subscriptions.Any(s => s.Status != "Live"); i++)
{
Assert.AreNotEqual(5, i, "Reached too many retries to get all subscriptions live!");
Assert.AreNotEqual(20, i, "Reached too many retries to get all subscriptions live!");

await Task.Delay(500);
await Task.Delay(1000);
resp = await GetSubscriptions();
}

Expand Down
4 changes: 2 additions & 2 deletions src/EventStore.Core.XUnit.Tests/Authorization/StreamBasedAuthPolicyRegistryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
using EventStore.Core.Authorization;
using EventStore.Core.Authorization.AuthorizationPolicies;
using EventStore.Core.Bus;
using EventStore.Core.Messages;
using EventStore.Core.Data;
using EventStore.Core.Messages;
using EventStore.Core.Messaging;
using EventStore.Core.Services;
using EventStore.Core.TransactionLog.LogRecords;
Expand All @@ -35,7 +35,7 @@ public class StreamBasedAuthPolicyRegistryTests
PropertyNamingPolicy = JsonNamingPolicy.CamelCase
};

private static readonly TimeSpan Timeout = TimeSpan.FromSeconds(5);
private static readonly TimeSpan Timeout = TimeSpan.FromSeconds(10);

private StreamBasedAuthorizationPolicyRegistry CreateSut(
FakePolicySelectorPlugin[] plugins, AuthorizationPolicySettings defaultSettings,
Expand Down
Loading