Skip to content

chore(auth): quiet policy evaluator test diagnostics#348

Merged
yordis merged 2 commits into
masterfrom
yordis/chore-auth-test-analyzers
May 13, 2026
Merged

chore(auth): quiet policy evaluator test diagnostics#348
yordis merged 2 commits into
masterfrom
yordis/chore-auth-test-analyzers

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 13, 2026

  • Keep authorization tests aligned with current analyzer guidance.
  • Reduce low-value diagnostics around policy evaluator coverage.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 13, 2026

PR Summary

Low Risk
Low risk: test-only refactor that switches to index-from-end access and makes helpers static, with no production code changes.

Overview
Updates MultiPolicyEvaluatorTests to reduce diagnostic/analyzer noise by making CreateSut/CreatePolicy static and replacing result.Matches.Last() with result.Matches[^1] when asserting on the final match.

Reviewed by Cursor Bugbot for commit afe7c00. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 31 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c5aca0ae-8e30-4453-b31f-db8a017fd2f8

📥 Commits

Reviewing files that changed from the base of the PR and between 92e4a69 and afe7c00.

📒 Files selected for processing (1)
  • src/EventStore.Core.XUnit.Tests/Authorization/MultiPolicyEvaluatorTests.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-auth-test-analyzers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

yordis added 2 commits May 13, 2026 12:01
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/chore-auth-test-analyzers branch from 8eafddf to afe7c00 Compare May 13, 2026 16:01
@yordis yordis merged commit 7c9ee02 into master May 13, 2026
22 checks passed
@yordis yordis deleted the yordis/chore-auth-test-analyzers branch May 13, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant