Skip to content

chore(auth): quiet policy evaluator test diagnostics #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 2 commits into from
May 13, 2026
+4 −5
Merged

chore(auth): quiet policy evaluator test diagnostics #348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48d411b
chore(auth): quiet policy evaluator test diagnostics
yordis May 13, 2026
afe7c00
chore(auth): fix policy test formatting
yordis May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/EventStore.Core.XUnit.Tests/Authorization/MultiPolicyEvaluatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ public class MultiPolicyEvaluatorTests
private ClaimsPrincipal _cp = new();
private const string TestAction = "read";

private MultiPolicyEvaluator CreateSut(Policy[] policies)
private static MultiPolicyEvaluator CreateSut(Policy[] policies)
{
var selectors = policies
.Select(x => new StaticPolicySelector(x.AsReadOnly()))
.ToArray<IPolicySelector>();
return new MultiPolicyEvaluator(new StaticAuthorizationPolicyRegistry(selectors));
}

private Policy CreatePolicy(string policyName, TestAssertion[] assertions)
private static Policy CreatePolicy(string policyName, TestAssertion[] assertions)
{
var policy = new Policy(policyName, 1, DateTimeOffset.MinValue);
foreach (var assertion in assertions)
Expand Down Expand Up @@ -93,7 +93,7 @@ private async Task AssertDeniedByDefault(MultiPolicyEvaluator sut, string[] reso
{
var result = await sut.EvaluateAsync(_cp, new Operation(resource, TestAction), _ct);
Assert.Equal(Grant.Deny, result.Grant);
Assert.Contains("denied by default", result.Matches.Last().Assertion.ToString());
Assert.Contains("denied by default", result.Matches[^1].Assertion.ToString());
}
}

Expand All @@ -103,8 +103,7 @@ private async Task AssertGrantForResources(MultiPolicyEvaluator sut, Grant expec
{
var result = await sut.EvaluateAsync(_cp, new Operation(resource, TestAction), _ct);
Assert.Equal(expectedGrant, result.Grant);
Assert.Contains(TestAssertion.Name, result.Matches.Last().Assertion.ToString());
Assert.Contains(TestAssertion.Name, result.Matches[^1].Assertion.ToString());
}
}
}

Loading