Avoid GC_add_current_malloc_heap overhead.#101
Open
joncham wants to merge 1 commit intounity-masterfrom
Open
Conversation
Add check for GC_no_win32_dlls to avoid unnecessary malloc heap registration when not needed.
UnityAlex
approved these changes
Jun 4, 2025
TautvydasZilys
approved these changes
Jun 5, 2025
ivmai
suggested changes
Feb 24, 2026
| struct GC_malloc_heap_list *new_l; | ||
| void * candidate; | ||
|
|
||
| if (!GC_no_win32_dlls) return; |
There was a problem hiding this comment.
Condition is wrong. Should be: if (GC_no_win32_dlls) return;
|
I've fixed the condition and upsreamed the patch - see f99ab74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for GC_no_win32_dlls to avoid unnecessary malloc heap registration when not needed.