Skip to content

Avoid GC_add_current_malloc_heap overhead. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joncham wants to merge 1 commit into
base: unity-master
Choose a base branch
from
+7 −3
Open

Avoid GC_add_current_malloc_heap overhead. #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions os_dep.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,9 +1822,13 @@ void GC_register_data_segments(void)

GC_INNER void GC_add_current_malloc_heap(void)
{
struct GC_malloc_heap_list *new_l =
malloc(sizeof(struct GC_malloc_heap_list));
void * candidate = GC_get_allocation_base(new_l);
struct GC_malloc_heap_list *new_l;
void * candidate;

if (!GC_no_win32_dlls) return;
Copy link
Copy Markdown

@ivmai ivmai Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Condition is wrong. Should be: if (GC_no_win32_dlls) return;


new_l = malloc(sizeof(struct GC_malloc_heap_list));
candidate = GC_get_allocation_base(new_l);

if (new_l == 0) return;
if (GC_is_malloc_heap_base(candidate)) {
Expand Down