Skip to content

fix: update tests to match SDK type alias changes#50

Merged
damaz91 merged 3 commits into
mainfrom
fix/avoid-root-model-compat
Jul 13, 2026
Merged

fix: update tests to match SDK type alias changes#50
damaz91 merged 3 commits into
mainfrom
fix/avoid-root-model-compat

Conversation

@damaz91

@damaz91 damaz91 commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updates the conformance tests to maintain compatibility with the Python SDK changes where root models (like PaymentHandler and ReverseDomainName) were converted to type aliases.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, including removal of schema files or fields)
  • Documentation update

Is this a Breaking Change or Removal?

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

Breaking Changes / Removal Justification

(N/A - This PR is a compatibility fix, not a breaking change itself.)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (pre-commit passes, tests compiled)
  • Any dependent changes have been merged and published in downstream modules

damaz91 added 2 commits July 10, 2026 15:06
@damaz91
fix: update tests to match SDK type alias changes
72825b3 
Updates test code to match the SDK changes where root models (like PaymentHandler and ReverseDomainName) were converted to type aliases:
- Use payment_handler.Base instead of payment_handler.PaymentHandler constructor.
- Remove fdc_req.FulfillmentDestinationCreateRequest wrapper and use shipping_destination.ShippingDestination directly.
- Use TypeAdapter to validate ReverseDomainName instead of instantiating it.

TAG=agy
CONV=8eec77fa-d0ae-4394-9976-9a7bafa71f51
@damaz91
style: fix linter and formatting errors
95ad744
@damaz91 damaz91 mentioned this pull request Jul 10, 2026
Closed
11 tasks
@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:under-review and removed status:needs-triage Signal that the PR is ready for human triage labels Jul 10, 2026
This was referenced Jul 10, 2026
Merged
Closed
@damaz91
damaz91 merged commit f3c7b9a into main Jul 13, 2026
23 checks passed
@damaz91
damaz91 deleted the fix/avoid-root-model-compat branch July 13, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carolinerg1 carolinerg1 carolinerg1 approved these changes
@ptiper ptiper ptiper approved these changes

Assignees

No one assigned

Labels

status:under-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damaz91 @carolinerg1 @ptiper