Skip to content

Report posterior bootstrap progress on completion rather than dispatch - #23

Open
devonjkohler with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-bootstrap-progress-reporting
Open

devonjkohler with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-bootstrap-progress-reporting

Conversation

Copilot AI commented Sep 17, 2026

Copy link
Copy Markdown

Posterior graph estimation currently advances the bootstrap progress bar when runs are queued, so progress reaches 100% before computation actually finishes. This change makes progress reflect completed bootstrap work.

  • Progress accounting moved to job completion

    • Added a small joblib callback context manager that increments tqdm when each parallel batch completes.
    • Restores the original joblib callback after execution to avoid cross-call side effects.
  • run_bootstrap progress flow updated

    • Replaced submission-time progress (tqdm(range(n_bootstrap))) with a completion-driven tqdm(total=n_bootstrap) wrapped around Parallel(...).
    • Kept bootstrap execution behavior unchanged; only progress signaling semantics changed.
with _tqdm_joblib(tqdm(total=n_bootstrap, desc="Hill Climb runs")):
    bootstrap_dags = Parallel(n_jobs=-2)(
        delayed(process_bootstrap)(..., seed=i, ...)
        for i in range(n_bootstrap)
    )

Co-authored-by: devonjkohler <35807256+devonjkohler@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 084d3eb5-ff65-41da-8b02-d1a2b48a63ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devonjkohler
devonjkohler marked this pull request as ready for review September 17, 2026 13:44
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.81%. Comparing base (acc6f3b) to head (c9e81ca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   69.69%   69.81%   +0.12%     
==========================================
  Files          36       36              
  Lines        3550     3565      +15     
==========================================
+ Hits         2474     2489      +15     
  Misses       1076     1076              
Flag Coverage Δ
py3.11 69.81% <100.00%> (+0.12%) ⬆️
py3.12 69.81% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants