fix documentation for dataProcess and groupComparison - #221
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe changes update ChangesDocumentation alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This updates dataProcess and groupComparison documentation to accurately describe current inputs, outputs, field names, labels, and missingness proportions. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit updates each careful line Comment |
Motivation and Context
Fixed parts of dataProcess() and groupComparison() documentation to match the utils_output.R.
The @return blocks of the above functions return different/more objects (verified against live output on DDARawData) that weren't documented.
Changes
NumMeasuredFeaturestoNumMeasuredFeaturein both @return blocks.@paramraw now states it takes a data.frame, not the name of a data set.Testing
No changes required here. I ran devtools::document()
Checklist Before Requesting a Review
Motivation and context
The documentation for
dataProcess()andgroupComparison()did not match the current output fields. This update aligns the source documentation and generated.Rdfiles with the implemented outputs.Changes
dataProcess()documentation.rawaccepts an MSstats long-format data frame.NumMeasuredFeaturestoNumMeasuredFeature.SummaryMethod,LABEL,remove, and conditional feature fields.groupComparison()documentation with matching field names and label information..Rdfiles.Tests
dataProcess()andgroupComparison().devtools::document()completed without new warnings.Coding guidelines