Add benchmark dataset inventory - #22
Open
swaraj-neu wants to merge 1 commit into
Open
swaraj-neu wants to merge 1 commit into
swaraj-neu wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference note from going through the benchmark folder on Explorer. Closes #2.
Mostly a working note so this doesn't live only in my head. No close review needed, just flag anything wrong.
Two things worth a look:
Format coverage. With TMT out of scope, there's data for five label-free formats: MaxQuant, FragPipe, DIA-NN, Spectronaut, MetaMorpheus. The plan assumed around seven for the results table. We can source more data, count instrument variants separately, or report five and note the limit. Flagging early since it affects benchmarking.
Pre-processing scope, and I'd like an answer on this one. The Solivais script does a lot before calling the converter: dropping semicolon-packed protein groups, dropping decoys, joining
QuantifiedProteins.tsvto get the organism, then tagging protein names with| ECOLIor| HUMAN. The species labels the FDR calculation needs aren't in the raw file.My reading: that's dataset curation, not format mapping, so it sits outside the LLM and the benchmark applies the same pre-processing to both paths. Does that match how you'd scope it?
Also: should this go to
main, or do you want adevelbranch here like the other packages?