Skip to content

Correct GROUND_TRUTH mappings against converter source - #25

Open
swaraj-neu wants to merge 1 commit into
mainfrom
fix/ground-truth-mappings
Open

swaraj-neu wants to merge 1 commit into
mainfrom
fix/ground-truth-mappings

Conversation

@swaraj-neu

Copy link
Copy Markdown

Correct GROUND_TRUTH mappings against converter source

Five entries listed source columns that do not match what the hand-written
MSstatsConvert converters use.

  • proteome_discoverer Intensity: PDtoMSstatsFormat defaults which.quantification
    to Precursor.Area, not Intensity
  • spectronaut ProductCharge: clean_Spectronaut resolves F.Charge or F.FrgZ
  • spectronaut PeptideSequence: PEP.StrippedSequence is never accepted as a fallback
  • metamorpheus PeptideSequence: Base Sequence is not in req_cols
  • metamorpheus PrecursorCharge: Peak Charge is not in req_cols

Closes #24

- Correct PD, Spectronaut, and MetaMorpheus columns
- Remove unsupported fallback mappings
@swaraj-neu swaraj-neu self-assigned this Sep 19, 2026
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a651ec21-bb79-43a0-afa8-867051cafa88


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct GROUND_TRUTH mappings against converter source

1 participant