This repository was archived by the owner on Jul 11, 2026. It is now read-only.
Conversation
|
Important Review skippedToo many files! This PR contains 266 files, which is 116 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (266)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Zarr v3 support to the DuckDB Zarr extension, including local v3 metadata discovery and expanded test coverage with v3 fixtures and an OME-Zarr v3 sample store.
Changes:
- Extend table functions to support explicit version overrides (
auto/v2/v3) and add v3-focused test coverage. - Add new v3 fixtures (
simple_v3.zarr) plus a real-world OME-Zarr v3 fixture (idr0062A/6001240_labels.zarr) and update fixture generation. - Add a Python smoke test runner + documentation and Makefile target for running it.
Reviewed changes
Copilot reviewed 25 out of 263 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/include/zarr_metadata.hpp |
Switches table function registrations to TableFunctionSet to support overloads (e.g., version override args). |
src/zarr_metadata.cpp |
Implements TableFunctionSet overloads for the Zarr functions (seen via context search). |
test/sql/duckdb_zarr.test |
Adds SQLLogic tests for v3 discovery, chunk enumeration, and cell scans (including sharded OME-Zarr v3 fixture). |
scripts/create_sample_zarr.py |
Adds generator for the simple_v3.zarr fixture. |
test/python_smoke.py |
Adds a Python-side smoke test that loads the extension and queries v2/v3 fixtures (optionally IDR fixture). |
test/data/simple_v3.zarr/** |
Adds a small Zarr v3 fixture store and chunk payloads. |
test/data/idr0062A/6001240_labels.zarr/** |
Adds a larger real-world OME-Zarr v3 fixture including sharded/Blosc data. |
README.md / test/README.md / ARCHITECTURE.md / ROADMAP.md |
Updates docs to reflect v3 support, limitations, and how to run the Python smoke example. |
Makefile |
Adds test_python_example target to run the Python smoke script. |
.gitignore |
Ignores decompressed extension artifacts and release asset patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 264 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.