Add arrow advantages figure and caption for clarity#44
Merged
Conversation
gwaybio
approved these changes
Jul 15, 2026
Member
There was a problem hiding this comment.
Looks good! A few comments
- please remove all excess text in the figures (see below; please prioritize this above other fixes in the repo, and send to me when ready, thanks!
- clarify the y axis "OME-Arrow speedup vs. OME-Zarr"
- Please add details (outside the figure, probably in the readme, about each of the datasets.) I'm hoping to see details on size, most notably, but also super brief details on the dataset purpose/experimental design
- When you say "profile-scale", do you mean "dataset-scale"?
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
gwaybio
approved these changes
Jul 15, 2026
gwaybio
left a comment
gwaybio
left a comment
Member
There was a problem hiding this comment.
Please reduce white space between figure rows, then all set!
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Member
Author
|
Thanks @gwaybio, merging this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates and adds a new figure for describing where and how ome-arrow is advantageous over ome-zarr.