fix(cli): preserve chunk names for inline -e scripts - #2
Merged
Merged
Conversation
Fix -e chunk loading so the inline source length is passed separately from its diagnostic chunk name. The regression coverage verifies successful execution and syntax-error reporting. Co-authored-by: CoinBaseSupp <239860209+CoinBaseSupp@users.noreply.github.com>
Add regression coverage for -e execution and diagnostic chunk names. Co-authored-by: CoinBaseSupp <239860209+CoinBaseSupp@users.noreply.github.com>
Align the regression assertion with the CLI diagnostic format while preserving the chunk-name check. Co-authored-by: CoinBaseSupp <239860209+CoinBaseSupp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI -e path passed the chunk name in the size parameter to luaL_loadbuffer, leaving the diagnostic name undefined.
This fixes the argument order and adds regression coverage for inline execution and syntax-error locations.