Magnifying glass improvements (macOS)#566
Open
starlit-void wants to merge 3 commits into
Open
Conversation
In single-page mode Viewer::grabMagnifiedRegion built the magnified image with a device pixel ratio of devicePixelRatioF() in the out-of-bounds branch, while the in-bounds branch returns a DPR-1 image and the source crop is itself DPR 1. A QPainter draws in logical coordinates, so painting the DPR-1 crop onto a DPR-2 (Retina) image scaled the content up by the ratio and clipped it. Because this only happens once the sampled region touches the page edge, magnification jumped discontinuously near the left/right edges and edge detail was pushed off the loupe. Keep the out-of-bounds image at DPR 1 so both branches produce the same scale.
The magnifying glass size actions and the page zoom actions both default to + and -. While the magnifying glass is visible both sets were enabled, making those shortcuts ambiguous so neither fired (the glass zoom */_ and reset / kept working because they are unique). Disable the page zoom actions while the magnifying glass is visible so its size actions own + and -.
…tive With the magnifying glass active, moving the cursor to the bottom of the page hit the goToFlow page-selection hover zone. The bar did not visibly appear, but the hover handling took over the mouse events there, so the magnifying glass stopped following the cursor and could not reach the bottom of the page. Skip the bottom hover zone while the magnifying glass is shown.
Member
|
I changed the default shortcuts here: 57b46fa I am still not sure if we should disable the actions or not :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tiny bugfixes in one PR:
Passed clang-format, tested on macOS. I'm happy to make any changes if needed.
AI was used but I Know What I'm Doing™️.
Thank you!