Skip to content

Magnifying glass improvements (macOS) #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
starlit-void wants to merge 2 commits into
base: develop
Choose a base branch
from
+8 −2
Open

Magnifying glass improvements (macOS) #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c4d79a
Fix magnifying glass zoom jump at image edges on HiDPI displays
starlit-void Jul 24, 2026
1241e82
Don't trigger the page-selection bar while the magnifying glass is ac…
starlit-void Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion YACReader/mouse_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ void YACReader::MouseHandler::mouseMoveEvent(QMouseEvent *event)
if (gtfPos.y() < 0 || gtfPos.x() < 0 || gtfPos.x() > viewer->goToFlow->width()) // TODO this extra check is for Mavericks (mouseMove over goToFlowGL seems to be broken)
viewer->animateHideGoToFlow();
// goToFlow->hide();
} else {
} else if (!viewer->magnifyingGlassShown) {
// Don't pop up the bottom page-selection bar while the
// magnifying glass is active: it prevents magnifying that area.
int umbral = (viewer->width() - viewer->goToFlow->width()) / 2;
if ((position.y() > viewer->height() - 15) && (position.x() > umbral) && (position.x() < viewer->width() - umbral)) {

Expand Down
6 changes: 5 additions & 1 deletion YACReader/viewer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,8 +1070,12 @@ QImage Viewer::grabMagnifiedRegion(const QPoint &viewerPos, const QSize &glassSi
}

if (outImage) {
// The magnified image is kept at source resolution (device pixel ratio 1),
// matching the in-bounds path below. Do NOT set a >1 device pixel ratio here:
// a QPainter draws in logical coordinates, so painting the DPR-1 source crop
// onto a DPR>1 image would scale the content up by the ratio (and clip it),
// producing a sudden magnification jump at the image edges on HiDPI displays.
QImage img(zoomWScaled, zoomHScaled, QImage::Format_RGB32);
img.setDevicePixelRatio(devicePixelRatioF());
img.fill(bgColor);
if (zw > 0 && zh > 0) {
QPainter painter(&img);
Expand Down