Skip to content

fix: guard viewer initialization after disposal - #258

Merged
alecdotdev merged 2 commits into
alecdotdev:masterfrom
PathGao:codex/guard-viewer-disposal
Jul 29, 2026
Merged

fix: guard viewer initialization after disposal#258
alecdotdev merged 2 commits into
alecdotdev:masterfrom
PathGao:codex/guard-viewer-disposal

Conversation

@PathGao

@PathGao PathGao commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #257.

Summary

  • Mark MarkdownViewer initialization as disposed during teardown.
  • Stop deferred syntax/math imports, session restore, initial file loading, and startup-path handling once disposed.
  • Release listeners whose registration completed after the component was destroyed.

Validation

  • node --test --import tsx scripts/viewerDisposal.test.ts
  • npm run check

@PathGao
PathGao force-pushed the codex/guard-viewer-disposal branch 2 times, most recently from 939716b to 36914d6 Compare July 28, 2026 05:46
@PathGao
PathGao force-pushed the codex/guard-viewer-disposal branch from 36914d6 to 4907165 Compare July 29, 2026 07:05
@PathGao

PathGao commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev This branch has been rebased and force-pushed. It depends on the latest #254 branch; please merge #254 first, then this PR, followed by #260 and #266. Validation passed: node --test --import tsx scripts/viewerDisposal.test.ts and npm run check.

@alecdotdev
alecdotdev merged commit 3ea8987 into alecdotdev:master Jul 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: stop MarkdownViewer initialization after component disposal

2 participants