Skip to content

Fix the sysrule#2891

Open
huangyiminghappy wants to merge 2 commits intoalibaba:masterfrom
huangyiminghappy:fix_the_sysrule
Open

Fix the sysrule#2891
huangyiminghappy wants to merge 2 commits intoalibaba:masterfrom
huangyiminghappy:fix_the_sysrule

Conversation

@huangyiminghappy
Copy link
Copy Markdown

Describe what this PR does / why we need it

All rules, including flowrule,degradeRule rules and even AbstractRule, are constructed using builder pattern to set attributes,In order to unify the use of rules and code style, we should set the SystemRule

Does this pull request fix one issue?

Describe how you did it

builder pattern to set attributes in SystemRule

Describe how to verify it

set attribute

Special notes for reviews

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ nullhuangyiming
❌ huangyiminghappy


nullhuangyiming seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sczyh30
Copy link
Copy Markdown
Member

sczyh30 commented Sep 26, 2022

Hi, thanks for contributing. This may lead to breaking changes (of API) and we might have to be careful of backward compatibility.

@huangyiminghappy
Copy link
Copy Markdown
Author

thank you reply,we just add builder pattern in set method,and return it self replace no return , Theoretically it can not lead to breaking changes (of API)

@sczyh30 sczyh30 added the api-change Issues or PRs related to api changes label Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Issues or PRs related to api changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants