Fix the sysrule#2891
Open
huangyiminghappy wants to merge 2 commits intoalibaba:masterfrom
Open
Conversation
merge new code
…ng the parent class AbstractRule
|
nullhuangyiming seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
Hi, thanks for contributing. This may lead to breaking changes (of API) and we might have to be careful of backward compatibility. |
Author
|
thank you reply,we just add builder pattern in set method,and return it self replace no return , Theoretically it can not lead to breaking changes (of API) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
All rules, including flowrule,degradeRule rules and even AbstractRule, are constructed using builder pattern to set attributes,In order to unify the use of rules and code style, we should set the SystemRule
Does this pull request fix one issue?
Describe how you did it
builder pattern to set attributes in SystemRule
Describe how to verify it
set attribute
Special notes for reviews