Skip to content

Fix the sysrule #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangyiminghappy wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −5
Open

Fix the sysrule #2891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a482c1
Merge pull request #1 from alibaba/master
huangyiminghappy Sep 24, 2022
271783f
systemRule use builder pattern,Be consistent with other Rules,Includ…
Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/system/SystemRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,9 @@ public double getQps() {
*
* @param qps max total QOS, values <= 0 are special for clearing the threshold.
*/
public void setQps(double qps) {
public SystemRule setQps(double qps) {
this.qps = qps;
return this;
}

public long getMaxThread() {
Expand All @@ -75,8 +76,9 @@ public long getMaxThread() {
*
* @param maxThread max parallel thread number, values <= 0 are special for clearing the threshold.
*/
public void setMaxThread(long maxThread) {
public SystemRule setMaxThread(long maxThread) {
this.maxThread = maxThread;
return this;
}

public long getAvgRt() {
Expand All @@ -88,8 +90,9 @@ public long getAvgRt() {
*
* @param avgRt max average response time, values <= 0 are special for clearing the threshold.
*/
public void setAvgRt(long avgRt) {
public SystemRule setAvgRt(long avgRt) {
this.avgRt = avgRt;
return this;
}

public double getHighestSystemLoad() {
Expand All @@ -109,8 +112,9 @@ public double getHighestSystemLoad() {
* @param highestSystemLoad highest system load, values <= 0 are special for clearing the threshold.
* @see SystemRuleManager
*/
public void setHighestSystemLoad(double highestSystemLoad) {
public SystemRule setHighestSystemLoad(double highestSystemLoad) {
this.highestSystemLoad = highestSystemLoad;
return this;
}

/**
Expand All @@ -127,8 +131,9 @@ public double getHighestCpuUsage() {
*
* @param highestCpuUsage the value to set.
*/
public void setHighestCpuUsage(double highestCpuUsage) {
public SystemRule setHighestCpuUsage(double highestCpuUsage) {
this.highestCpuUsage = highestCpuUsage;
return this;
}

@Override
Expand Down