refactor(@angular/build): extract shared concurrency, watcher, and styling utilities - #34110
Open
alan-agius4 wants to merge 1 commit into
Open
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several refactorings and new features, including the extraction of file watcher setup logic into a reusable setupWatcher helper, the addition of a dataurl option to inline stylesheet resources as base64 data URIs, and the introduction of new concurrency utilities (runConcurrent and mapConcurrent) to handle limited-concurrency asynchronous operations. Additionally, the getTailwindConfig helper was moved to postcss-configuration.ts. Feedback on these changes highlights a potential memory leak in setupWatcher where the 'abort' event listener registered on the AbortSignal is not removed when the watcher is closed.
alan-agius4
force-pushed
the
refactor/build-shared-utils
branch
2 times, most recently
from
September 17, 2026 17:49
181d5af to
838d09e
Compare
alan-agius4
force-pushed
the
refactor/build-shared-utils
branch
from
September 17, 2026 18:09
838d09e to
6a226cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract shared utilities from the application builder so they can be reused across builders:
runConcurrentandmapConcurrentintoutils/concurrency.tssetupWatcherintotools/esbuild/watcher.tsgetTailwindConfigintoutils/postcss-configuration.tsresolvePathonBuilderHarness