feat: [performance improvement] optimize ScheduleContainer filtering by using Set by anyulled · Pull Request #245 · anyulled/devbcn-nextjs

anyulled · 2026-05-26T08:36:39Z

💡 What: Converted the savedSessionIds array into a Set within the useMemo block in ScheduleContainer.tsx before iterating through the schedule to filter saved sessions.

🎯 Why: The original code used savedSessionIds.includes(s.id) inside a .filter() method. Since .includes() is an O(N) operation and it was called for every session (M sessions), the overall complexity was O(N * M). By using a Set, the .has() lookup becomes O(1), making the filtering process O(N + M).

📊 Impact: Reduces the time complexity of filtering the schedule from O(N * M) to O(N + M), resulting in faster component renders, especially for users with many saved sessions and large event schedules.

🔬 Measurement: A microbenchmark shows Set.has taking ~9ms compared to Array.includes taking ~385ms for 100k lookups. Rendering tests (ScheduleGrid.perf.test.tsx) continue to pass quickly.

PR created automatically by Jules for task 12605011761638486732 started by @anyulled

Summary by CodeRabbit

Refactor
- Improved schedule filtering performance for saved sessions while maintaining existing behavior for service sessions.

…by using Set Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

google-labs-jules · 2026-05-26T08:36:40Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

vercel · 2026-05-26T08:36:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
devbcn-nextjs	Error		May 26, 2026 8:36am

qodo-code-review · 2026-05-26T08:36:44Z

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

coderabbitai · 2026-05-26T08:36:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22d2427d-a235-44a9-a71a-39b0696ddf3a

📥 Commits

Reviewing files that changed from the base of the PR and between 6513720 and 78598e4.

📒 Files selected for processing (1)

components/schedule/ScheduleContainer.tsx

📝 Walkthrough

Walkthrough

ScheduleContainer's saved-session filtering logic is optimized by constructing a Set from savedSessionIds and switching the membership test from Array.includes() to Set.has() when filtering GridSession items while preserving the rule that service sessions are always included.

Changes

Session Filter Optimization

Layer / File(s)	Summary
Optimized saved-session filter with Set lookup `components/schedule/ScheduleContainer.tsx`	The `useMemo` filter now creates a `Set` from `savedSessionIds` and uses `savedSessionIdsSet.has(s.id)` instead of `savedSessionIds.includes(s.id)` for O(1) lookup time while maintaining existing service session inclusion logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested labels

size/XS

Poem

🐰 A set replaces the list so slow,
Hash lookup makes the filtering flow,
O of one beats O of n,
Sessions render swift again! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: optimizing ScheduleContainer's filtering logic by converting an array to a Set for better performance.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch bolt-perf-schedule-filter-12605011761638486732

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request optimizes the session filtering logic in ScheduleContainer.tsx by converting savedSessionIds to a Set to reduce filtering complexity from O(N*M) to O(N + M). The reviewer suggests a further holistic improvement to store savedSessionIds as a Set directly in ScheduleContext to avoid reconstructing the set on every memoization run and optimize other operations.

gemini-code-assist · 2026-05-26T08:37:23Z

+    const savedSessionIdsSet = new Set(savedSessionIds);
+    const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionIdsSet.has(s.id) || s.isServiceSession);


While converting savedSessionIds to a Set here is a great optimization that reduces the filtering complexity to O(N + M), we still incur an O(N) cost to reconstruct the Set on every memoization run when savedSessionIds or initialSchedule changes.

A more holistic improvement would be to store savedSessionIds as a Set<string> directly in ScheduleContext. This would:

Eliminate the need to reconstruct the Set here (making this O(1) setup).

Optimize isSaved in ScheduleContext from O(N) to O(1) (currently using Array.prototype.includes).

Optimize toggleSession in ScheduleContext from O(N) to O(1).

Since ScheduleContext.tsx is not modified in this PR, you can consider this as a follow-up refactoring.

feat: [performance improvement] optimize ScheduleContainer filtering …

78598e4

…by using Set Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

github-actions Bot added the size/size/XS label May 26, 2026

vercel Bot had a problem deploying to Preview – devbcn-nextjs May 26, 2026 08:36 Failure

gemini-code-assist Bot reviewed May 26, 2026

View reviewed changes

coderabbitai Bot approved these changes May 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [performance improvement] optimize ScheduleContainer filtering by using Set#245

feat: [performance improvement] optimize ScheduleContainer filtering by using Set#245
anyulled wants to merge 1 commit into
mainfrom
bolt-perf-schedule-filter-12605011761638486732

anyulled commented May 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

google-labs-jules Bot commented May 26, 2026

Uh oh!

vercel Bot commented May 26, 2026 •

edited

Loading

Uh oh!

qodo-code-review Bot commented May 26, 2026

Uh oh!

coderabbitai Bot commented May 26, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		const savedSessionIdsSet = new Set(savedSessionIds);
		const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionIdsSet.has(s.id) \|\| s.isServiceSession);

Conversation

anyulled commented May 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

google-labs-jules Bot commented May 26, 2026

Uh oh!

vercel Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-code-review Bot commented May 26, 2026

Qodo reviews are paused for this user.

Uh oh!

coderabbitai Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

anyulled commented May 26, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 26, 2026 •

edited

Loading

coderabbitai Bot commented May 26, 2026 •

edited

Loading