Skip to content

feat: [performance improvement] optimize ScheduleContainer filtering by using Set #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anyulled wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: [performance improvement] optimize ScheduleContainer filtering by using Set #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/schedule/ScheduleContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export default function ScheduleContainer({ initialSchedule, year }: Readonly<Sc
return initialSchedule;
}

const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionIds.includes(s.id) || s.isServiceSession);
const savedSessionIdsSet = new Set(savedSessionIds);
const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionIdsSet.has(s.id) || s.isServiceSession);
Comment on lines +23 to +24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While converting savedSessionIds to a Set here is a great optimization that reduces the filtering complexity to O(N + M), we still incur an O(N) cost to reconstruct the Set on every memoization run when savedSessionIds or initialSchedule changes.

A more holistic improvement would be to store savedSessionIds as a Set<string> directly in ScheduleContext. This would:

  • Eliminate the need to reconstruct the Set here (making this O(1) setup).
  • Optimize isSaved in ScheduleContext from O(N) to O(1) (currently using Array.prototype.includes).
  • Optimize toggleSession in ScheduleContext from O(N) to O(1).

Since ScheduleContext.tsx is not modified in this PR, you can consider this as a follow-up refactoring.


return initialSchedule.map((day) => ({
...day,
Expand Down
Loading