GH-49803: [C++][CI] Avoid aborting when fuzz-mutated IPC file has less batches#49804
Open
pitrou wants to merge 1 commit intoapache:mainfrom
Open
GH-49803: [C++][CI] Avoid aborting when fuzz-mutated IPC file has less batches#49804pitrou wants to merge 1 commit intoapache:mainfrom
pitrou wants to merge 1 commit intoapache:mainfrom
Conversation
pitrou
changed the title
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: 2f7386e Submitted crossbow builds: ursacomputing/crossbow @ actions-cebef960c7
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The IPC file fuzzer can remove batches from the IPC file footer while the batches do exist physically in the embedded IPC stream.
This causes problem in differential fuzzing, because comparing the results of the IPC stream reader against the IPC file reader then fails.
This issue was found by OSS-Fuzz: https://issues.oss-fuzz.com/issues/503357759
What changes are included in this PR?
Skip differential fuzzing against the IPC stream reader if the number of batches read from the IPC file footer is not equal.
Are these changes tested?
Yes, by existing fuzz regression file.
Are there any user-facing changes?
No.