GH-50904: [C++] Replace RapidJSON with simdjson in OpaqueType - #50905
Merged
Merged
Conversation
kou
reviewed
Aug 19, 2026
github-actions
Bot
added
awaiting changes
github-actions
Bot
added
awaiting change review
Reranko05
force-pushed
the
gh-35460-extension2
branch
from
August 19, 2026 14:53
00479f3 to
36b95cd
Compare
This was referenced Aug 19, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit df824c1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 106 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Member
|
@kou @Reranko05 Can we please revisit this and use an approach that adds less boilerplate? For example we could use the DOM API rather than the on-demand API. We could also build some higher-level helpers around the simdjson APIs. |
This was referenced Sep 9, 2026
pitrou
pushed a commit
that referenced
this pull request
Sep 9, 2026
…#51253) ### Rationale for this change This revisits the implementation based on the review feedback from #50905 (comment) and uses Arrow's existing `JsonObjectParser` helper to provide a higher-level interface over simdjson. ### Changes - Replace manual simdjson On-Demand parsing in `OpaqueType::Deserialize()` with `JsonObjectParser`. - Use `JsonObjectParser::GetString()` to retrieve the required `type_name` and `vendor_name` fields. - Remove manual JSON object iteration, key handling, and explicit JSON type checks. - Update `OpaqueType::Deserialize` tests to verify invalid input is rejected without relying on exact error messages. Fixes: #51252 * GitHub Issue: #51252 Authored-by: Aaditya Srinivasan <aadityasri03@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR continues the simdjson migration by replacing the remaining RapidJSON usage in
OpaqueTypeundercpp/src/arrow/extensionwith the existing simdjson helpers and On-Demand API.The existing deserialization validation and behavior are preserved, with tests updated for parser-specific error messages.
Changes
OpaqueType::Deserialize()with simdjson.ResolveSimdjsonResult()helper.opaque.cc.