GH-51013: [C++] Replace RapidJSON in JSON test utilities by Reranko05 · Pull Request #51014 · apache/arrow

Reranko05 · 2026-08-26T22:58:33Z

Rationale for this change

This PR continues the simdjson migration by replacing RapidJSON usage in the C++ JSON test and testing utilities with simdjson and Arrow's existing JsonWriter.

Changes

Replace rapidjson::Writer and StringBuffer usage in JSON test utilities with JsonWriter.
Replace RapidJSON-based JSON pretty-printing with simdjson's fractured_json_string().
Replace RapidJSON DOM parsing in TensorFromJSON() with simdjson's DOM API.
Add test coverage for TensorFromJSON() with strides and dimension names.
Update test linking to include arrow::simdjson.

GitHub Issue: [C++] Replace RapidJSON in remaining JSON test utilities #51013

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Reranko05 · 2026-09-07T14:54:11Z

@pitrou Could you review this when you have time. (CI failures seem unrelated)

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Reranko05 · 2026-09-08T04:50:23Z

@pitrou, I have made the dicussed changes. (CI failures doesnt seem related)

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

pitrou

+1, thanks for doing this work @Reranko05 !

pitrou · 2026-09-08T08:44:08Z

@github-actions crossbow submit -g cpp

github-actions · 2026-09-08T08:49:19Z

Revision: 259feaf

Submitted crossbow builds: ursacomputing/crossbow @ actions-f8a3b2cdad

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-debian-13-cpp-amd64
test-debian-13-cpp-i386
test-debian-experimental-cpp-gcc-15
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

Reranko05 · 2026-09-08T08:49:54Z

@pitrou Thanks for the review!

pitrou · 2026-09-08T09:35:25Z

CI failures are unrelated, I'll merge.

github-actions Bot added Component: C++ awaiting review Awaiting review labels Aug 26, 2026

Reranko05 force-pushed the gh-35460-tests branch from 932f311 to 8ed2513 Compare August 26, 2026 23:04

Reranko05 added the CI: Extra: C++ Run extra C++ CI label Aug 26, 2026

Reranko05 marked this pull request as ready for review August 27, 2026 12:19

Reranko05 requested a review from pitrou as a code owner August 27, 2026 12:19

Copilot AI lite review requested due to automatic review settings August 27, 2026 12:19

Copilot AI reviewed Aug 27, 2026

Reranko05 requested review from kou and rok August 27, 2026 12:20

pitrou reviewed Aug 27, 2026

View reviewed changes

github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Aug 27, 2026

Copilot AI review requested due to automatic review settings September 7, 2026 04:00

Reranko05 force-pushed the gh-35460-tests branch from 1d4aa67 to b008578 Compare September 7, 2026 04:00

Copilot AI reviewed Sep 7, 2026

Reranko05 added 5 commits September 7, 2026 10:00

Replace in gtest_util

4338ca9

Replace in test_commons

15e5cb7

Add meson dep

f015bc7

Replace with JsonWriter

a300b1b

add cmake dep

7d391d2

Copilot AI review requested due to automatic review settings September 7, 2026 04:32

Reranko05 force-pushed the gh-35460-tests branch from b008578 to 7d391d2 Compare September 7, 2026 04:32

Copilot AI reviewed Sep 7, 2026

restore simdjson_internal

6e34b70

Copilot AI review requested due to automatic review settings September 7, 2026 04:34

Copilot AI reviewed Sep 7, 2026

Copilot AI review requested due to automatic review settings September 7, 2026 05:10

Copilot AI reviewed Sep 7, 2026

Copilot AI review requested due to automatic review settings September 7, 2026 05:17

Copilot AI review requested due to automatic review settings September 7, 2026 05:18

Reranko05 force-pushed the gh-35460-tests branch from e3c7376 to 91923b0 Compare September 7, 2026 05:18

Copilot AI reviewed Sep 7, 2026

WIP: Move PrettyPrintJsonValue to simdjson_internal.cc

4155b6c

Copilot AI review requested due to automatic review settings September 7, 2026 05:47

Reranko05 force-pushed the gh-35460-tests branch from 91923b0 to 4155b6c Compare September 7, 2026 05:47

Copilot AI reviewed Sep 7, 2026

Reranko05 mentioned this pull request Sep 7, 2026

GH-51140: [C++] Require simdjson 4.3.0 for fractured_json APIs #51142

Merged

Copilot AI review requested due to automatic review settings September 7, 2026 13:50

Copilot AI reviewed Sep 7, 2026

Reranko05 force-pushed the gh-35460-tests branch from cf2afcd to f7d4ee3 Compare September 7, 2026 13:55

Address Feedback

1c9d675

Reranko05 force-pushed the gh-35460-tests branch from f7d4ee3 to 1c9d675 Compare September 7, 2026 14:13

Use fractured_json_string and remove PrettyPrintJsonValue

2cbac54

Copilot AI review requested due to automatic review settings September 8, 2026 03:47

Copilot AI reviewed Sep 8, 2026

Remove test that's not really useful

259feaf

Copilot AI review requested due to automatic review settings September 8, 2026 08:42

Copilot AI reviewed Sep 8, 2026

pitrou reviewed Sep 8, 2026

View reviewed changes

Comment thread cpp/src/arrow/json/parser_test.cc Outdated

pitrou approved these changes Sep 8, 2026

View reviewed changes

pitrou merged commit f14ae5b into apache:main Sep 8, 2026
66 of 71 checks passed

pitrou removed the awaiting committer review Awaiting committer review label Sep 8, 2026

pitrou mentioned this pull request Sep 8, 2026

[C++] Replace RapidJSON in remaining JSON test utilities #51013

Closed

Uh oh!

Conversation

Reranko05 commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reranko05 commented Sep 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reranko05 commented Sep 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pitrou left a comment

Choose a reason for hiding this comment

Uh oh!

pitrou commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

Reranko05 commented Sep 8, 2026

Uh oh!

pitrou commented Sep 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Reranko05 commented Aug 26, 2026 •

edited

Loading