Skip to content

GH-51140: [C++] Require simdjson 4.3.0 for fractured_json APIs - #51142

Merged
kou merged 1 commit into
apache:mainfrom
tadeja:simdjson_required_v4.3.0
Sep 3, 2026
Merged

kou merged 1 commit into
apache:mainfrom
tadeja:simdjson_required_v4.3.0

Conversation

@tadeja

@tadeja tadeja commented Sep 2, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Fix #51140, CMake configuration should not accept simdjson earlier than v4.3.0.

What changes are included in this PR?

Set ARROW_SIMDJSON_REQUIRED_VERSION to "4.3.0"

Are these changes tested?

Yes. Locally, CMake configuration rejects system simdjson 4.2.3 now
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:316 (message):
Couldn't find simdjson >= 4.3.0

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #51140 has been automatically assigned in GitHub to PR creator.

@tadeja
tadeja marked this pull request as ready for review September 2, 2026 15:09
Copilot AI lite review requested due to automatic review settings September 2, 2026 15:09
@tadeja

tadeja commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-build-vcpkg-win test-ubuntu-22.04-cpp-bundled

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped, matches the documented minimum simdjson API requirement, and reduces the risk of configuration-time acceptance of incompatible system versions.

Pull request overview

Updates the C++ third-party dependency configuration to require simdjson >= 4.3.0, matching the minimum version needed for the fractured_json APIs used in Arrow and preventing misconfigured builds with older system simdjson installs.

Changes:

  • Bump ARROW_SIMDJSON_REQUIRED_VERSION from 4.0.0 to 4.3.0 in the CMake toolchain dependency resolution.
File summaries
File Description
cpp/cmake_modules/ThirdpartyToolchain.cmake Raises the minimum accepted simdjson version to avoid build failures when system simdjson is < 4.3.0.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Revision: f3018b3

Submitted crossbow builds: ursacomputing/crossbow @ actions-0a31401513

Task Status
test-build-vcpkg-win GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions

@tadeja
tadeja requested a review from kou September 2, 2026 17:51

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Sep 3, 2026
@kou
kou merged commit 8ebb636 into apache:main Sep 3, 2026
55 of 57 checks passed
@kou kou removed the awaiting merge Awaiting merge label Sep 3, 2026
@rok

rok commented Sep 3, 2026

Copy link
Copy Markdown
Member

Regarding simdjson version - we had a version discussion here already - #50568 (comment). TLDR: ubuntu lags, only 26.0.10 has 4.6.8, while 26.0.4 has 4.2.4.

@Reranko05

Copy link
Copy Markdown
Collaborator

Regarding simdjson version - we had a version discussion here already - #50568 (comment). TLDR: ubuntu lags, only 26.0.10 has 4.6.8, while 26.0.4 has 4.2.4.

@pitrou Should we use fractured_json_string like suggested in #51014 (comment), or should I avoid it for compatibility with older simdjson versions?

@pitrou

pitrou commented Sep 7, 2026

Copy link
Copy Markdown
Member

Regarding simdjson version - we had a version discussion here already - #50568 (comment). TLDR: ubuntu lags, only 26.0.10 has 4.6.8, while 26.0.4 has 4.2.4.

Do you suggest we support simdjson 1.0.2 to be compatible with Ubuntu 22.04?

@Reranko05

Copy link
Copy Markdown
Collaborator

Do you suggest we support simdjson 1.0.2 to be compatible with Ubuntu 22.04?

I think that's okay, never mind. We can't go that far back anyway :)

@rok

rok commented Sep 7, 2026

Copy link
Copy Markdown
Member

(In case you're asking me too) @pitrou I don't have a strong opinion. As per @kou we can bundle: #50568 (comment)

@tadeja
tadeja deleted the simdjson_required_v4.3.0 branch September 11, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Require simdjson 4.3.0 for fractured_json APIs

6 participants