GH-51271: [Ruby] Fix Date values in ArrowFormat::Date32Array - #51272
Merged
Conversation
kou
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ArrowFormat::Date32Arraycurrently storesDate#day, the day of the month, for RubyDatevalues. Arrow Date32 values are signed day offsets from the Unix epoch, so this can silently produce incorrect data. The same conversion is used byArrowFormat::Array.buildwhen it infers Date32.What changes are included in this PR?
Datevalues from their Julian day to the Unix epoch day offset.Are these changes tested?
Yes. The full
red-arrow-formatsuite passes locally: 691 tests and 695 assertions. The official rake runner used the current pure-Ruby sources with the locally installed Arrow 25.0.1 native extension; the local system does not have the Arrow C++ 26 dependency needed to build the native Ruby extension frommain.Are there any user-facing changes?
Yes. Ruby
Datevalues now produce specification-compliant Date32 day offsets.This PR contains a "Critical Fix". It fixes incorrect Date32 data produced from Ruby
Datevalues.AI assistance
AI assistance was used to investigate the defect, draft the focused implementation and tests, and run the verification described above. No human review is claimed.