Skip to content

GH-51271: [Ruby] Fix Date values in ArrowFormat::Date32Array #51272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Sep 11, 2026
+15 −1
Merged

GH-51271: [Ruby] Fix Date values in ArrowFormat::Date32Array #51272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bff566f
GH-51271: [Ruby] Fix Date values in ArrowFormat::Date32Array
emecii Sep 10, 2026
b848efb
GH-51271: Address Date32 review feedback
emecii Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ruby/red-arrow-format/lib/arrow-format/array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# under the License.

require "bigdecimal"
require "date"

require_relative "array-builder"
require_relative "bitmap"
Expand Down Expand Up @@ -489,11 +490,12 @@ def type
end

private
UNIX_EPOCH = Date.new(1970, 1, 1).jd
def pack_value(value, template, type)
if value.nil?
[0].pack(template)
elsif value.is_a?(Date)
[value.day].pack(template)
[value.jd - UNIX_EPOCH].pack(template)
else
[value].pack(template)
end
Expand Down
12 changes: 12 additions & 0 deletions ruby/red-arrow-format/test/test-date32-array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ def test_mixed
assert_equal(values,
ArrowFormat::Date32Array.new(values).to_a)
end

def test_date
values = [
Date.new(1969, 12, 31),
Date.new(1970, 1, 1),
nil,
Date.new(2025, 12, 9),
]
expected = [-1, 0, nil, @date_2025_12_09]
assert_equal(expected,
ArrowFormat::Date32Array.new(values).to_a)
end
end

sub_test_case("#==") do
Expand Down
Loading