GH-51474: [Python][Annotations] Add pyrefly check to CI - #51475
Open
samwgoldman wants to merge 1 commit into
Open
samwgoldman wants to merge 1 commit into
samwgoldman wants to merge 1 commit into
Conversation
Run pyrefly alongside mypy, pyright, and ty in ci/scripts/python_test_type_annotations.sh, with a [tool.pyrefly] section in python/pyproject.toml that mirrors the existing checkers (check only pyarrow-stubs, resolve pyarrow from pyarrow-stubs first, Python 3.11), and document it in the developer guide.
samwgoldman
requested review from
AlenkaF,
assignUser,
jonkeane,
kou,
raulcd and
rok
as code owners
September 23, 2026 20:31
|
|
github-actions
Bot
added
Component: Python
Component: Documentation
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
pyarrow's stubs are checked with mypy, pyright, and ty (#48618). This adds pyrefly, as discussed in #48622 (comment).
What changes are included in this PR?
ci/scripts/python_test_type_annotations.shinstalls pyrefly and runspyrefly check --summarize-errorsafter the other checkers.python/pyproject.tomlgets a[tool.pyrefly]section that mirrors the existing configs: it checks onlypyarrow-stubs, targets Python 3.11, and putspyarrow-stubson the search path soimport pyarrowresolves to the stubs rather than the source package.Are these changes tested?
Locally,
ci/scripts/python_test_type_annotations.shpasses with all four checkers onmain. I also checked the stubs from #48622 (7 stub files, about 1,070 lines): all four checkers report 0 errors, and pyrefly takes about 0.2s. Pyrefly also reports an error planted in a stub, so it's checking the stubs rather than skipping them.Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: