Skip to content

[improvement](fe) Set minimum scanner concurrency to 4 - #68374

Open
HappenLee wants to merge 1 commit into
apache:masterfrom
HappenLee:improvement/min-scanners-concurrency-4
Open

HappenLee wants to merge 1 commit into
apache:masterfrom
HappenLee:improvement/min-scanners-concurrency-4

Conversation

@HappenLee

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: #63389

Problem Summary:

New sessions currently use min_scanners_concurrency = 1. Raise this default to 4 and update its description so regular scans use a higher concurrency floor under the existing scanner-count, concurrency, and memory limits. Serial scans continue to use one scanner.

Expression ZoneMap filtering is already enabled by default on master (enable_expr_zonemap_filter = true).

Release note

Increase the default min_scanners_concurrency from 1 to 4 for new sessions.

Check List (For Author)

  • Test: FE unit tests and Checkstyle passed.
    • MAVEN_ARGS='-T 48' bash run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest,org.apache.doris.qe.VariableMgrTest: 31 tests, 0 failures/errors/skips.
    • mvn -T 48 checkstyle:check -pl fe-core (from fe/): 0 violations.
    • git diff --check: passed.
  • Behavior changed: Yes. New sessions default to a minimum scanner concurrency of 4.
  • Does this need documentation: No. The session-variable description is updated with the new default.

### What problem does this PR solve?

Issue Number: None

Related PR: apache#63389

Problem Summary:

New sessions currently use `min_scanners_concurrency = 1`. Raise this default to `4` and update its description so regular scans use a higher concurrency floor under the existing scanner-count, concurrency, and memory limits. Serial scans continue to use one scanner.

Expression ZoneMap filtering is already enabled by default on master (`enable_expr_zonemap_filter = true`).

### Release note

Increase the default `min_scanners_concurrency` from `1` to `4` for new sessions.

### Check List (For Author)

- Test: FE unit tests and Checkstyle passed.
    - `MAVEN_ARGS='-T 48' bash run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest,org.apache.doris.qe.VariableMgrTest`: 31 tests, 0 failures/errors/skips.
    - `mvn -T 48 checkstyle:check -pl fe-core` (from `fe/`): 0 violations.
    - `git diff --check`: passed.
- Behavior changed: Yes. New sessions default to a minimum scanner concurrency of 4.
- Does this need documentation: No. The session-variable description is updated with the new default.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants