[FLINK-40668][network] Document why the recovery drain cannot stall on zero-credit needsRecovery channels - #29190
Open
1996fanrui wants to merge 1 commit into
Open
1996fanrui wants to merge 1 commit into
1996fanrui wants to merge 1 commit into
Conversation
…n zero-credit needsRecovery channels
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A needsRecovery
RemoteInputChannelstarts with zero server credit, andupstreamReadyisopened only by
onBuffer(), which makes it look like the recovery drain could stall. It cannot:the upstream always emits
EndOfOutputChannelStateEventat recovery init, and events bypass thezero-credit gate, so
onBuffer()fires and opens the latch. This adds a comment making thatreasoning explicit.
Brief change log
onBuffer()latchcountDowninRemoteInputChannel.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation