Skip to content

[FLINK-40668][network] Document why the recovery drain cannot stall on zero-credit needsRecovery channels #29190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1996fanrui wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-40668][network] Document why the recovery drain cannot stall on zero-credit needsRecovery channels #29190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,9 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog, int subpart
boolean recycleBuffer = true;

// The first buffer from the producer proves the upstream reader is registered and the
// connection is live; release any recovery-side awaiter. On later buffers this is a cheap
// connection is live; release any recovery-side awaiter (see requestRecoveryBufferBlocking).
// During recovery this first arrival is typically the upstream's EndOfOutputChannelStateEvent,
// which is guaranteed and passes the zero-credit gate. On later buffers this is a cheap
// idempotent no-op (the latch count is already zero).
upstreamReady.countDown();

Expand Down