[chore] Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull#2290
Conversation
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelXmlFactoryTest.java
Show resolved
Hide resolved
Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNullModernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull
… custom null checks with Objects.requireNonNull
Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNullObjects.requireNonNull
impl/maven-impl/src/main/java/org/apache/maven/impl/ImplUtils.java
Outdated
Show resolved
Hide resolved
… custom null checks with Objects.requireNonNull
… custom null checks with Objects.requireNonNull
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultArtifactCoordinatesFactory.java
Show resolved
Hide resolved
impl/maven-impl/src/main/java/org/apache/maven/impl/AbstractSession.java
Show resolved
Hide resolved
Objects.requireNonNullObjects.requireNonNull
Objects.requireNonNullObjects.requireNonNull
elharo
left a comment
There was a problem hiding this comment.
I thought we already did this, but I guess not
merge not. It seems that its convention here to to merge immediately so others can review too. Might enable an auto merge after 10 days non rejected. |
Not rejected does not mean approved (at least for me) and taken into account how large Maven is, that the Maven team is not a company and the current situation about cyber attacks (including AI generated ones) I don't think auto merges are a good idea. |
I am totally against any automerges. |
|
yes, its a security risk not haven taken into account. Thanks for hint. |
|
@olamy any feedback from your side? If not might consider merge. Its just renaming of old method to new one, therefore no delta possible, and removal. No risky s&r brute force. |
Modernize codebase with Java improvements - Replace custom null checks with
Objects.requireNonNulltoList()instead ofCollectors.toList()) #2287