HDDS-16113. Add regression tests for snapshot defragmentation cleanup - #10978
Draft
smengcl wants to merge 1 commit into
Draft
HDDS-16113. Add regression tests for snapshot defragmentation cleanup#10978smengcl wants to merge 1 commit into
smengcl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage in Ozone Manager’s snapshot defragmentation test suite to ensure temporary checkpoint directories are cleaned up on failure paths, and validates old-checkpoint cleanup behavior when a snapshot is already defragmented.
Changes:
- Add tests asserting checkpoint directory cleanup when opening a defrag checkpoint fails.
- Add tests asserting cleanup of partial checkpoint directories when
DBStore#getCheckpoint(...)returnsnull. - Update existing “already defragged” path test to expect deletion of older checkpoint versions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: Codex (GPT-5.6 Sol)
What changes were proposed in this pull request?
Add regression tests for the snapshot defragmentation cleanup and deletion-retry paths introduced by HDDS-13173.
What is the link to the Apache JIRA?
https://issues.apache.org/jira/browse/HDDS-16113
How was this patch tested?
TestSnapshotDefragServicepassed.