Skip to content

HDDS-16113. Add regression tests for snapshot defragmentation cleanup #10978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smengcl wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −1
Open

HDDS-16113. Add regression tests for snapshot defragmentation cleanup #10978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion ...r/src/test/java/org/apache/hadoop/ozone/om/snapshot/defrag/TestSnapshotDefragService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,41 @@ public void close() {
}
}

@Test
public void testCreateCheckpointCleansUpAfterOpenFailure() throws Exception {
SnapshotInfo snapshotInfo = createMockSnapshotInfo(UUID.randomUUID(), "vol1", "bucket1", "snap1");
Path checkpointPath = tempDir.resolve("tmp_defrag").resolve("checkpoint-" + UUID.randomUUID());
Files.createDirectories(checkpointPath);
DBCheckpoint checkpoint = new RocksDBCheckpoint(checkpointPath);
DBStore snapshotStore = mock(DBStore.class);
when(snapshotStore.getCheckpoint(anyString(), eq(true))).thenReturn(checkpoint);
createMockSnapshot(snapshotInfo, snapshotStore);

SnapshotDefragService spyDefragService = Mockito.spy(defragService);
Mockito.doThrow(new IOException("Failed to open checkpoint"))
.when(spyDefragService).createDefragCheckpointMetadataManager(eq(checkpoint), eq(false));

org.junit.jupiter.api.Assertions.assertThrows(IOException.class,
() -> spyDefragService.createCheckpoint(snapshotInfo, COLUMN_FAMILIES_TO_TRACK_IN_SNAPSHOT));
assertFalse(Files.exists(checkpointPath));
}

@Test
public void testCreateCheckpointCleansUpWhenStoreReturnsNull() throws Exception {
SnapshotInfo snapshotInfo = createMockSnapshotInfo(UUID.randomUUID(), "vol1", "bucket1", "snap1");
String dbName = "snapshot-" + UUID.randomUUID();
Path partialCheckpoint = tempDir.resolve("tmp_defrag").resolve(dbName + "_checkpoint_1");
Files.createDirectories(partialCheckpoint);
DBStore snapshotStore = mock(DBStore.class);
when(snapshotStore.getCheckpoint(anyString(), eq(true))).thenReturn(null);
when(snapshotStore.getDbLocation()).thenReturn(tempDir.resolve(dbName).toFile());
createMockSnapshot(snapshotInfo, snapshotStore);

org.junit.jupiter.api.Assertions.assertThrows(IOException.class,
() -> defragService.createCheckpoint(snapshotInfo, COLUMN_FAMILIES_TO_TRACK_IN_SNAPSHOT));
assertFalse(Files.exists(partialCheckpoint));
}

@Test
public void testDefragCheckpointMetadataManagerSkipsRocksDBMetrics() throws Exception {
Path checkpointPath = tempDir.resolve("defrag-metrics-" + UUID.randomUUID());
Expand Down Expand Up @@ -1036,9 +1071,10 @@ public void testCheckAndDefragAlreadyDefraggedSnapshot() throws IOException {
try (MockedStatic<SnapshotUtils> mockedStatic = Mockito.mockStatic(SnapshotUtils.class)) {
mockedStatic.when(() -> SnapshotUtils.getSnapshotInfo(eq(ozoneManager), eq(chainManager),
eq(snapshotInfo.getSnapshotId()))).thenReturn(snapshotInfo);
doReturn(Pair.of(false, 0)).when(spyDefragService).needsDefragmentation(eq(snapshotInfo));
doReturn(Pair.of(false, 2)).when(spyDefragService).needsDefragmentation(eq(snapshotInfo));
assertFalse(spyDefragService.checkAndDefragSnapshot(chainManager, snapshotInfo.getSnapshotId()));
verify(snapshotMetrics).incNumSnapshotDefragSnapshotSkipped();
verify(omSnapshotManager).deleteSnapshotCheckpointDirectories(snapshotInfo.getSnapshotId(), 1);
}
}

Expand Down