Skip to content

PDFBOX-6286: Clear page-tree visited state on lookup errors #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AryanRG wants to merge 2 commits into from
Closed

PDFBOX-6286: Clear page-tree visited state on lookup errors #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6610bf8
PDFBOX-6286: Scope page-tree recursion state to each lookup
AryanRG Oct 17, 2026
6301182
PDFBOX-6286: Clear visited pages before lookup errors
AryanRG Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ private COSDictionary get(int pageNum, COSDictionary node, int encountered)
{
if (pageNum < 1)
{
pageSet.clear();
throw new IndexOutOfBoundsException("Index out of bounds: " + pageNum);
}
if (pageSet.contains(node))
Expand Down Expand Up @@ -357,10 +358,12 @@ private COSDictionary get(int pageNum, COSDictionary node, int encountered)
}
}

pageSet.clear();
throw new IllegalStateException("1-based index not found: " + pageNum);
}
else
{
pageSet.clear();
throw new IndexOutOfBoundsException("1-based index out of bounds: " + pageNum);
}
}
Expand All @@ -373,6 +376,7 @@ private COSDictionary get(int pageNum, COSDictionary node, int encountered)
}
else
{
pageSet.clear();
throw new IllegalStateException("1-based index not found: " + pageNum);
}
}
Expand Down
16 changes: 16 additions & 0 deletions pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertThrows;

import java.io.IOException;

Expand Down Expand Up @@ -133,6 +135,20 @@ void testInsertAfterBlankPage() throws IOException
}
}

@Test
void getValidPageAfterOutOfBoundsLookup() throws IOException
{
try (PDDocument document = new PDDocument())
{
PDPage page = new PDPage();
document.addPage(page);
PDPageTree pages = document.getPages();

assertThrows(IndexOutOfBoundsException.class, () -> pages.get(1));
assertSame(page.getCOSObject(), pages.get(0).getCOSObject());
}
}

/**
* PDFBOX-6040: avoid loop in getInheritableAttribute().
*
Expand Down