SOLR-18383: remove CollectionParams.FROM_NODE - #4769
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Open
Conversation
Deprecated since 10.0 in favor of SOURCE_NODE. 0 remaining references after removing the constant and its 2 usages in MoveReplicaCmd/CollectionsHandler. AI-assisted (Claude Sonnet 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18383
Removes
CollectionParams.FROM_NODE, deprecated since 10.0 in favor ofSOURCE_NODE. 4 sites (constant + its 2 usages inMoveReplicaCmd/CollectionsHandler+ the v2 mapping already gone). 0 remaining references anywhere; no dedicated test existed for the legacy alias.2 tests, 0 failures (MoveReplicaTest, sanity check on MoveReplicaCmd).
SOLR-18370 (local, not yet a PR) also touches CollectionsHandler.java and CollectionParams.java -- re-check once it opens a PR.
AI-assisted (Claude Sonnet 5)