Skip to content

SOLR-18383: remove CollectionParams.FROM_NODE #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-bzhezytskyy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SOLR-18383: remove CollectionParams.FROM_NODE #4769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/unreleased/SOLR-18383-remove-collectionparams-from-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
title: Remove the deprecated `fromNode` request parameter of the MOVEREPLICA Collections API command; use `sourceNode` instead.
type: removed
authors:
- name: Serhiy Bzhezytskyy
links:
- name: SOLR-18383
url: https://issues.apache.org/jira/browse/SOLR-18383
9 changes: 2 additions & 7 deletions solr/core/src/java/org/apache/solr/cloud/api/collections/MoveReplicaCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,11 @@ private void moveReplica(
"Collection: " + collection + " replica: " + replicaName + " does not exist");
}
} else {
String sourceNode =
message.getStr(CollectionParams.SOURCE_NODE, message.getStr(CollectionParams.FROM_NODE));
String sourceNode = message.getStr(CollectionParams.SOURCE_NODE);
if (sourceNode == null) {
throw new SolrException(
SolrException.ErrorCode.BAD_REQUEST,
"'"
+ CollectionParams.SOURCE_NODE
+ " or '"
+ CollectionParams.FROM_NODE
+ "' is a required param");
"'" + CollectionParams.SOURCE_NODE + "' is a required param");
}
String shardId = message.getStr(SHARD_ID_PROP);
if (shardId == null) {
Expand Down
1 change: 0 additions & 1 deletion solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,6 @@ public Map<String, Object> execute(
return copy(
req.getParams(),
map,
CollectionParams.FROM_NODE,
CollectionParams.SOURCE_NODE,
TARGET_NODE,
WAIT_FOR_FINAL_STATE,
Expand Down
5 changes: 0 additions & 5 deletions solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ public interface CollectionParams {

String NAME = "name";

/**
* @deprecated use {@link #SOURCE_NODE} instead
*/
@Deprecated String FROM_NODE = "fromNode";

String SOURCE_NODE = "sourceNode";
String TARGET_NODE = "targetNode";
String SOURCE_NODES = "sourceNodes";
Expand Down
Loading