fix(mqtt-out): keep Stop responsive when a publish blocks#17
Merged
Conversation
When the broker is unreachable the shared client's request queue fills and `publish().await` blocks, so the node never returned to its select to see the shutdown signal — it was aborted before releasing the shared connection, leaking the driver task (errors kept coming after Stop). Race the publish against the shutdown signal so Stop interrupts a blocked publish, lets the node release the connection, and the driver is aborted. Verified: Stop returns in ~0.5s and mqtt errors cease (previously kept erroring after Stop).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the broker is unreachable the shared client's request queue fills and
publish().awaitblocks, so the node never returned to its select to see the shutdown signal — it was aborted before releasing the shared connection, leaking the driver task (errors kept coming after Stop).Race the publish against the shutdown signal so Stop interrupts a blocked publish, lets the node release the connection, and the driver is aborted. Verified: Stop returns in ~0.5s and mqtt errors cease (previously kept erroring after Stop).