Skip to content

fix(mqtt-out): keep Stop responsive when a publish blocks #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashaffah merged 1 commit into from
Jun 29, 2026
Merged

fix(mqtt-out): keep Stop responsive when a publish blocks #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/runtime/nodes/mqtt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,11 +471,17 @@ impl Node for MqttOutNode {
status("error", "no_topic", Value::Null);
continue;
};
if let Err(e) = shared
.publish(&topic, self.qos, self.retain, value_to_bytes(&msg.payload))
.await
{
status("error", "publish_error", json!({ "error": e }));
// A publish blocks when the broker is down (the client's
// request queue fills). Race it against shutdown so Stop
// still works — otherwise the node is aborted before it
// can release the shared connection (driver leak).
tokio::select! {
_ = NodeCtx::shutdown_requested(&mut shutdown) => break,
r = shared.publish(&topic, self.qos, self.retain, value_to_bytes(&msg.payload)) => {
if let Err(e) = r {
status("error", "publish_error", json!({ "error": e }));
}
}
}
}
None => break,
Expand Down