Skip to content

OUT-4185: rename disconnect sync action to "Disable" - #287

Merged
SandipBajracharya merged 2 commits into
masterfrom
OUT-4185
Sep 14, 2026
Merged

SandipBajracharya merged 2 commits into
masterfrom
OUT-4185

Conversation

@SandipBajracharya

@SandipBajracharya SandipBajracharya commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

What

Renames the app-header action label from "Disconnect account" to "Disable sync" so it reads distinctly from the new Reset connection action added in OUT-4180. "Disable sync" is clearer about what's turned off (the QBO sync, not the user's account) and matches the app's vocabulary ("QuickBooks Sync"). Also renames the internal disconnectAction → disableAction and its error string for consistency.

Copy-only change — no behavior change (same enable: false call to change-enable-status).

Notes

  • The 'Disconnect' icon key is intentionally kept: the bridge Icons union (src/bridge/header.ts) has no Disable member, and the icon is rendered by the parent Copilot/Assembly dashboard. Label and icon are separate concerns.
  • Left untouched (out of scope — they describe the disconnected state, not this action): notification copy in notification.helper.ts and the isDisconnected gating flags.

Ref: OUT-4185 (per Adam's request on OUT-4180 — "Rename 'disconnect' action to 'disable'")

🤖 Generated with Claude Code

Renames the app-header action label from "Disconnect account" to
"Disable account" (and internal disconnectAction -> disableAction) so
it reads distinctly from the new Reset connection action. Copy-only,
no behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
quickbooks-sync Building Building Sep 14, 2026 2:33pm UTC
quickbooks-sync (dev) Ready Ready Preview Sep 14, 2026 2:33pm UTC

Request Review

@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

OUT-4185

@SandipBajracharya SandipBajracharya changed the title chore(OUT-4185): rename disconnect sync action to "Disable" OUT-4185: rename disconnect sync action to "Disable" Sep 14, 2026
@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the terminology changes are consistent and preserve existing behavior.

Summary

  • Renames the internal callback to disableAction.
  • Updates the associated error message.
  • Continues sending enable: false through the existing endpoint.

Reviews (1) · Last reviewed commit: "chore(OUT-4185): rename disconnect sync ..."

Clearer about what's being turned off (the QBO sync, not the user's
account) and matches app vocabulary ("QuickBooks Sync").

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@SandipBajracharya
SandipBajracharya merged commit 0a584f0 into master Sep 14, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
dev — e1980fed Deployed Sep 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant