Skip to content

OUT-4185: rename disconnect sync action to "Disable" #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandipBajracharya merged 2 commits into from
Sep 14, 2026
Merged

OUT-4185: rename disconnect sync action to "Disable" #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012d55b
chore(OUT-4185): rename disconnect sync action to "Disable"
SandipBajracharya Sep 14, 2026
e1980fe
chore(OUT-4185): use "Disable sync" label over "Disable account"
SandipBajracharya Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hook/useQuickbooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
return () => {
supabase.removeChannel(realtimeSyncChannel)
}
}, [])

Check warning on line 98 in src/hook/useQuickbooks.ts

View workflow job for this annotation

GitHub Actions / Run linters 

React Hook useEffect has missing dependencies: 'setAppParams' and 'tokenPayload?.workspaceId'. Either include them or remove the dependency array

// handle reconnect logic
useEffect(() => {
Expand All @@ -107,7 +107,7 @@
if (reconnect) {
handleAppConnect()
}
}, [reconnect])

Check warning on line 110 in src/hook/useQuickbooks.ts

View workflow job for this annotation

GitHub Actions / Run linters 

React Hook useEffect has a missing dependency: 'handleConnect'. Either include it or remove the dependency array

const getAuthUrl = async (type?: string) => {
setLoading(true)
Expand Down Expand Up @@ -287,15 +287,15 @@
connectionStatus: boolean | null
onReset: () => void
}) => {
const disconnectAction = async () => {
const disableAction = async () => {
const payload = {
enable: false,
}
const url = `/api/quickbooks/token/change-enable-status?token=${token}`
try {
await postFetcher(url, {}, payload, { timeoutMs: null })
} catch (err) {
console.error('Error disconnecting QuickBooks account', err)
console.error('Error disabling QuickBooks account', err)
}
}

Expand Down Expand Up @@ -326,9 +326,9 @@
...(isConnected && isEnabled && syncFlag
? [
{
label: 'Disconnect account',
label: 'Disable sync',
icon: 'Disconnect' as Icons,
onClick: disconnectAction,
onClick: disableAction,
},
]
: []),
Expand Down
Loading