Repository navigation
OUT-4184: make production deploy non-cancelable - #289
Merged
Merged
Conversation
Move concurrency from the workflow to the deploy job with cancel-in-progress: false. Workflow-level cancellation could stop an in-flight deploy when a newer push arrived; if that push then failed a check, neither commit deployed. Now deploys serialize and a running publish is never interrupted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
With serial (non-cancelable) deploys, a slower older run could publish after a newer one and leave production on stale code. Guard the deploy step: if this run's commit is no longer the branch tip, skip it so only the newest commit publishes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
@greptileai review again |
Collaborator
Author
|
@greptileai review |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #288 (merged). Moves the
deploy.ymlconcurrency from the workflow level to the deploy job, and flipscancel-in-progresstofalse.Why
The merged version used workflow-level
cancel-in-progress: true. That can cancel an in-flight production deploy when a newer push tomasterarrives — and if that newer push then fails a check, neither commit deploys, leaving production un-updated even though the earlier commit was good.This is the same P1 Greptile flagged on the sibling Dropbox integration PR. #288's only Greptile review predated the switch to
true, so it was never surfaced here.Fix
Deploys now serialize (a newer push waits) and a running publish is never interrupted. No check-cancellation is lost that matters — merges to
masterare infrequent, and every one gets checked and deployed in order.🤖 Generated with Claude Code