Repository navigation
docs: record exported API review and approval of E1-E6 - #6
Merged
ajbeck merged 2 commits intoSep 27, 2026
Merged
Conversation
Record decision 0026, a review of every exported identifier in edge, identity, authn, iamproof and authz against Google's Go style guide and the primary sources it links. It proposes seven separately approvable changes before the first release, lists the alternatives considered and not recommended, and leaves the resolution pending owner review.
ajbeck
added this pull request to stack #7
September 27, 2026 13:32
ajbeck
marked this pull request as ready for review
September 27, 2026 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds decision 0026, a review of every exported identifier in
edge,identity,authn,iamproofandauthz. The review is based on Google's Go style guide (guide, decisions and best practices, read in full) and the primary sources it links. This PR changes no code: it records proposals for owner review, as AGENTS.md requires for public API decisions.Stacked on #5.
Proposals (each separately approvable)
ActionHeaderout of the rootedgepackage into a standard-library-onlyactionheaderpackage. Today native HTTP consumers link the Lambda adapter just to select an action.ErrInvalidEvent,ErrMissingCredentials)identity.WithCallertoidentity.NewContext, pairing withFromContext. Every otherWith…function in the module is an option.InvocationErroroperation and limit names, which today are documented only in proseStringmethods on theidentityenums (todayCallerprintskind:2,source:4)authn), doc links, named callback parameters,Claim.Boolresult namesauthn/cognito(discretionary)The record also lists what was considered and not recommended, with reasons. That includes keeping the
Handlererror return, the explicitiamprooferror adapter, the sharededge.Optiontype and the current config styles. It also notes what is already conformant.Validation
go doc -alloutput and the accepted decision records. E1 reopens part of decision 0011; the record says so and asks the owner to confirm.git diff --checkis clean.Limitations