Repository navigation
refactor: move action-header selection to the actionheader package - #8
Merged
Merged
Conversation
Move edge.ActionHeader to the standard-library-only actionheader package as Selector, with NewSelector as its constructor. Native HTTP consumers no longer link the Lambda adapter and aws-lambda-go events just to select an action. Parsing behavior and sentinel meanings are unchanged; error strings now carry the actionheader prefix. BREAKING CHANGE: edge.ActionHeader, edge.NewActionHeader and edge.ErrAction* are now actionheader.Selector, actionheader.NewSelector and actionheader.ErrAction*.
ajbeck
added this pull request to stack #7
September 27, 2026 14:36
ajbeck
marked this pull request as ready for review
September 27, 2026 15:04
ajbeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements E1. Moves
edge.ActionHeader,NewActionHeaderand the action sentinels into the new standard-library-onlyactionheaderpackage, asSelectorandNewSelector. Parsing behavior is unchanged. The gateway-format andedge.Newcomposition tests stay inedge; the parse tests and the runnable example move with the package. README, guides, AGENTS.md, the dispatcher example and the external consumer source use the new package.Part of decision 0026, approved by the owner; stacked on #6.
Validation
gofmt,
go vet ./...,go mod verify,go test -race ./...,sh scripts/check-consumer.sh, Linux arm64/amd64 builds andgit diff --checkall pass locally on Go 1.27.1.Evidence:
go list -deps ./examples/dispatcher/nativeno longer includes the root adapter oraws-lambda-go/events.Breaking: import
actionheaderinstead ofedgefor action selection. Error strings now use theactionheader:prefix. The sentinels keep their old names until E2 (#9).