Repository navigation
refactor: rename action sentinels to drop the repeated context - #9
Merged
Merged
Conversation
Rename actionheader.ErrActionMissing, ErrActionAmbiguous and ErrActionInvalid to ErrMissing, ErrAmbiguous and ErrInvalid. The package name already supplies the action context, and the new names match the module's adjective-first sentinel convention. Error strings and meanings are unchanged. BREAKING CHANGE: actionheader.ErrAction* sentinels are now actionheader.ErrMissing, ErrAmbiguous and ErrInvalid.
ajbeck
added this pull request to stack #7
September 27, 2026 14:36
This was referenced Sep 27, 2026
ajbeck
marked this pull request as ready for review
September 27, 2026 15:04
ajbeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements E2. Renames
actionheader.ErrActionMissing,ErrActionAmbiguousandErrActionInvalidtoErrMissing,ErrAmbiguousandErrInvalid, matching the module's adjective-first sentinel names. Rename only: the error strings and meanings are unchanged.Part of decision 0026, approved by the owner; stacked on #8.
Validation
gofmt,
go vet ./...,go mod verify,go test -race ./...,sh scripts/check-consumer.sh, Linux arm64/amd64 builds andgit diff --checkall pass locally on Go 1.27.1.Breaking: the sentinel identifiers change.